Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grpc broker request handler not started correctly issue #7950

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

walterddr
Copy link
Contributor

broker request handler test is not started correctly with proper configuration.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #7950 (7c1845f) into master (6037cac) will decrease coverage by 2.96%.
The diff coverage is 70.15%.

❗ Current head 7c1845f differs from pull request most recent head 95db373. Consider uploading reports for the commit 95db373 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7950      +/-   ##
============================================
- Coverage     71.15%   68.18%   -2.97%     
+ Complexity     4111     4095      -16     
============================================
  Files          1593     1198     -395     
  Lines         82365    59720   -22645     
  Branches      12270     9208    -3062     
============================================
- Hits          58609    40722   -17887     
+ Misses        19806    16141    -3665     
+ Partials       3950     2857    -1093     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 68.18% <70.15%> (+0.11%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...not/core/operator/combine/BaseCombineOperator.java 78.37% <0.00%> (-9.46%) ⬇️
...core/query/executor/ServerQueryExecutorV1Impl.java 60.00% <0.00%> (-27.75%) ⬇️
...ocal/recordtransformer/ComplexTypeTransformer.java 55.67% <ø> (ø)
...ava/org/apache/pinot/spi/stream/LongMsgOffset.java 92.30% <ø> (ø)
...java/org/apache/pinot/spi/stream/MessageBatch.java 0.00% <0.00%> (ø)
...manager/realtime/LLRealtimeSegmentDataManager.java 45.27% <1.53%> (-26.57%) ⬇️
...t/index/loader/invertedindex/JsonIndexHandler.java 72.58% <76.19%> (-0.76%) ⬇️
...ent/index/loader/invertedindex/H3IndexHandler.java 73.52% <76.92%> (+0.09%) ⬆️
...ocal/segment/index/loader/SegmentPreProcessor.java 79.78% <81.08%> (+18.77%) ⬆️
.../index/loader/invertedindex/RangeIndexHandler.java 46.00% <86.36%> (+1.55%) ⬆️
... and 646 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6037cac...95db373. Read the comment docs.

@walterddr walterddr changed the title fix broker request handler not started correctly issue fix grpc broker request handler not started correctly issue Dec 22, 2021
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment

…tion/tests/GrpcBrokerClusterIntegrationTest.java

Co-authored-by: Xiaotian (Jackie) Jiang <[email protected]>
…tion/tests/GrpcBrokerClusterIntegrationTest.java
@Jackie-Jiang Jackie-Jiang merged commit 95bd5b1 into apache:master Dec 23, 2021
@walterddr walterddr deleted the hotfix_grpc_broker_test branch December 6, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants