-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix grpc broker request handler not started correctly issue #7950
fix grpc broker request handler not started correctly issue #7950
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7950 +/- ##
============================================
- Coverage 71.15% 68.18% -2.97%
+ Complexity 4111 4095 -16
============================================
Files 1593 1198 -395
Lines 82365 59720 -22645
Branches 12270 9208 -3062
============================================
- Hits 58609 40722 -17887
+ Misses 19806 16141 -3665
+ Partials 3950 2857 -1093
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comment
...tests/src/test/java/org/apache/pinot/integration/tests/GrpcBrokerClusterIntegrationTest.java
Outdated
Show resolved
Hide resolved
…tion/tests/GrpcBrokerClusterIntegrationTest.java Co-authored-by: Xiaotian (Jackie) Jiang <[email protected]>
...tests/src/test/java/org/apache/pinot/integration/tests/GrpcBrokerClusterIntegrationTest.java
Outdated
Show resolved
Hide resolved
…tion/tests/GrpcBrokerClusterIntegrationTest.java
broker request handler test is not started correctly with proper configuration.